Drop unnecessary check in RequirementSet.add_requirement #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm kinda torn on removing this code, since there is a small risk of potential breakage due to this change affecting things that I'm not expecting it to. |
|
That's a risk with anything, to mitigate it we usually simplify the code until it's obvious. We could do the same here. If we split RequirementSet into one case used for |
|
Makes sense to me! |
|
/me wonders if we should just drop this, since it might make more sense to ignore this method, and work with all the other abstractions that we have; for the new resolver. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While @pfmoore and I were walking through this code, we noticed that we'd never actually hit the case which this conditional guards against -- adding a constraint after adding requirements.
Filing as a PR, so that we can discuss concretely what we want to do here.